Pending transactions #1954
Merged
Pending transactions #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
force-pushed
the
ml/pending-transactions
branch
from
1b5b7d4
to
5f93feb
Compare
lubej
force-pushed
the
ml/pending-transactions
branch
3 times, most recently
from
b4cfe60
to
a3a0cb4
Compare
lukaw3d
reviewed
May 30, 2024
lubej
force-pushed
the
ml/pending-transactions
branch
11 times, most recently
from
5103383
to
cf5d71f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
- Coverage 79.82% 79.80% -0.03%
==========================================
Files 212 212
Lines 5467 5555 +88
Branches 1025 1059 +34
==========================================
+ Hits 4364 4433 +69
- Misses 1103 1122 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lubej
commented
Jun 6, 2024
lubej
force-pushed
the
ml/pending-transactions
branch
from
cf5d71f
to
cea904c
Compare
lubej
commented
Jun 6, 2024
| @@ -50,7 +53,16 @@ export function getOasisscanAPIs(url: string | 'https://api.oasisscan.com/mainne | |||
| return data | |||
| } | |||
|
|
|||
| async function getTransactionsList(params: { accountId: string; limit: number }): Promise<Transaction[]> { | |||
| async function getTransaction({ hash }: { hash: string }) { | |||
There was a problem hiding this comment.
TODO: Add cache mechanism, as transaction won't ever change once we already fetch it.
lubej
force-pushed
the
ml/pending-transactions
branch
5 times, most recently
from
52f8586
to
62c1711
Compare
lubej
force-pushed
the
ml/pending-transactions
branch
from
62c1711
to
daf6e15
Compare
lubej
force-pushed
the
ml/pending-transactions
branch
2 times, most recently
from
2a37deb
to
0e77efa
Compare
lukaw3d
approved these changes
Jul 10, 2024
src/app/pages/AccountPage/Features/TransactionHistory/__tests__/index.test.tsx
Outdated
Show resolved
Hide resolved
src/app/pages/AccountPage/Features/TransactionHistory/__tests__/index.test.tsx
Outdated
Show resolved
Hide resolved
lubej
force-pushed
the
ml/pending-transactions
branch
2 times, most recently
from
7273e31
to
21b1d9b
Compare
- needs better UX in case it updates, like flash or some animation
lubej
force-pushed
the
ml/pending-transactions
branch
from
21b1d9b
to
09083aa
Compare
lukaw3d
reviewed
Jul 11, 2024
| yield* put(accountActions.transactionsLoaded(transactions)) | ||
|
|
||
| const detailedTransactions = yield* call(() => | ||
| Promise.allSettled(transactions.map(({ hash }) => getTransaction({ hash }))), |
There was a problem hiding this comment.
This tries to incorrectly fetch paratime transactions too. See requests in:
https://wallet.dev.oasis.io/account/oasis1qry5d5zxs58w9deu5ara5zaamhkzqtg99s00ls90
There was a problem hiding this comment.
Right. Is there any better way to determine if the tx is a runtime tx -> #1999?
This was referenced Jul 11, 2024
This was referenced Aug 6, 2024
lukaw3d
added a commit
that referenced
this pull request
Sep 20, 2024
lukaw3d
added a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #1942. So the initial proposition was that we should decrease the time to fetch transactions. Which in my opinion does not solve the core issue, of not showing pending transaction. So this PR introduces a list of pending transactions, which should mitigate original issue in some way.
I wanted to introduce polling for each of the transactions, that would refresh the state of each pending transaction on each new block. But that introduces a state, where balance could be out of sync with the actual transaction history - also it would need a synchronous clock - which is also a hustle to implement, as the right approach IMO would be to refresh the balance/pending txs on each new block.
oasis.client.NodeInternalfunctionconsensusWatchBlocks, would be ideal for that case, but does not seems to work, either there is an issue with TS client implementation or the grpc node does not support the method.Resources